Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expanded normalization modifiers #434

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

ekourlit
Copy link
Contributor

@ekourlit ekourlit commented Sep 17, 2023

This PR expands the usage and notion of normalization modifiers. Now normalization modifiers can also come from weight or tree variations. For example, a weight-based systematic can define a variation from which a normalization effect is calculated.

This PR also allows the symmetrization of normalization systematics.

Changes are mainly affecting src/cabinetry/workspace.py where the workspace is created. src/cabinetry/configuration.py has also being changed so additional needed histograms are now build for normalization modifiers.

As a side note, it would be good to add a safety check during the creation of the configuration file in order to not allow different properties of Up and Down variations. For example, we might not want to allow:

  - Name: "my_systematic"
    Up:
      Weight: "<up-weight-string>"
    Down:
      Normalization: <up-factor>
    Type: "Normalization"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant